Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a workflow that cleans up after dependabot #1776

Merged
merged 3 commits into from
Jul 14, 2023

Conversation

maribethb
Copy link
Contributor

Adds a workflow that hopefully

  • runs any time a dependabot-created PR is opened, reopened, or synchronized (more commits are added)
  • runs npm run boot which runs lerna bootstrap in both plugins and examples
  • commits any resulting changes to the same dependabot-created PR
  • doesn't block dependabot from making further commits to the PR e.g. in response to a command to rebase

The reason this is needed is because when dependabot makes a PR it updates the package-lock for a plugin but doesn't run lerna bootstrap. The result is that plugins keep having local dependencies added to their package-locks by dependabot, and then later they might be removed when a human runs lerna bootstrap, cluttering up other PRs. These local dependencies should not be part of the package-lock files -- that's just how lerna works :/

No idea if it works as intended until we submit it and try to run it on a dependabot PR, but at the very least I'm pretty confident it shouldn't ruin anyone else's non-dependabot PRs.

@maribethb maribethb requested a review from a team as a code owner July 13, 2023 23:51
@maribethb maribethb requested review from BeksOmega and removed request for a team July 13, 2023 23:51
Copy link
Contributor

@BeksOmega BeksOmega left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! This is so clever and lovely :D

.github/workflows/dependabot_update.yml Outdated Show resolved Hide resolved
.github/workflows/dependabot_update.yml Show resolved Hide resolved
@maribethb maribethb merged commit af842ed into google:master Jul 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants